Skip to content

feat: Remove rebuild index of separated indexer - #2990

Merged
Keith-CY merged 1 commit into
nervosnetwork:developfrom
yanguoyu:feat-remove-rebuild-index
Dec 26, 2023
Merged

feat: Remove rebuild index of separated indexer#2990
Keith-CY merged 1 commit into
nervosnetwork:developfrom
yanguoyu:feat-remove-rebuild-index

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

Refer to Magickbase/neuron-public-issues#330

refresh.cache.mov

Comment thread packages/neuron-ui/src/locales/en.json Outdated
@homura

homura commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

It would be helpful if the description provided some context or reason for this PR

@yanguoyu
yanguoyu force-pushed the feat-remove-rebuild-index branch from 8695b82 to 4da35cc Compare December 15, 2023 03:48
@Keith-CY

Copy link
Copy Markdown
Contributor

It would be helpful if the description provided some context or reason for this PR

cc @yanguoyu

@yanguoyu

Copy link
Copy Markdown
Contributor Author

It would be helpful if the description provided some context or reason for this PR

cc @yanguoyu

I have added the issue that refers to this PR at #2990 (comment)

@Keith-CY

Copy link
Copy Markdown
Contributor

It would be helpful if the description provided some context or reason for this PR

cc @yanguoyu

I have added the issue that refers to this PR at #2990 (comment)

I see, please review again @homura

@homura homura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is LGTM, and I'd suggest that the tile could be changed to "remove rebuild index of separated indexer"

@yanguoyu yanguoyu changed the title feat: Remove rebuild indexer feat: Remove rebuild index of separated indexer Dec 19, 2023
@silySuper

silySuper commented Dec 26, 2023

Copy link
Copy Markdown

/package
Packaging for test is done in 7325706624. @silySuper

@Keith-CY
Keith-CY added this pull request to the merge queue Dec 26, 2023
Merged via the queue into nervosnetwork:develop with commit 4af44ea Dec 26, 2023
@yanguoyu
yanguoyu deleted the feat-remove-rebuild-index branch December 26, 2023 09:22
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants